fix: fallback_pr_lookup boolean check in Fastfile - #6672
Merged
Conversation
Fastlane's CLI handler (Fastlane::CommandLineHandler.convert_value) already coerces 'true' / 'false' CLI args into Ruby booleans before the lane sees them, so `options[:fallback_pr_lookup]` is the Ruby boolean `true`, not the string `"true"`. That made `== 'true'` always evaluate to false and silently disabled the fallback in CI even when `bump_with_fallback_pr_lookup: true` was requested. Compare against the actual Ruby boolean instead. `nil == true` is also false, so the "param not passed" case keeps defaulting to off. Made-with: Cursor
tonidero
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #6669. Fastlane's CLI handler coerces
true/falseargs into Ruby booleans before the lane sees them, sooptions[:fallback_pr_lookup] == 'true'is alwaysfalseand the fallback was silently disabled in CI. Compare against the Ruby boolean instead.Test plan
bumpworkflow withbump_with_fallback_pr_lookup: trueand confirm the fallback engages.Note
Low Risk
Low risk: a small Fastfile change that only affects how the
fallback_pr_lookuplane option is interpreted, with no production runtime impact outside release automation/CI.Overview
Fixes Fastlane lane option handling so
fallback_pr_lookupis enabled when the CLI passes a Ruby boolean, updating bothbumpandautomatic_bumpto compare againsttrueinstead of the string'true'.Reviewed by Cursor Bugbot for commit 74762ba. Bugbot is set up for automated code reviews on this repo. Configure here.