bug(cli): #1323 refine serving logic for node modules plugin

packages/cli/src/plugins/resource/plugin-active-content.js

@@ -73,7 +73,7 @@ class ContentAsDataResource {
   async shouldIntercept(url, request, response) {
     const { activeContent } = this.compilation.config;
 
-    return response.headers.get("Content-Type")?.indexOf(this.contentType[0]) >= 0 && activeContent;
+    return activeContent && response.headers.get("Content-Type")?.indexOf(this.contentType[0]) >= 0;
   }
 
   async intercept(url, request, response) {
@@ -138,7 +138,7 @@ class ContentAsDataResource {
   async shouldOptimize(url, response) {
     const { activeContent } = this.compilation.config;
 
-    return response.headers.get("Content-Type").indexOf(this.contentType[0]) >= 0 && activeContent;
+    return activeContent && response.headers.get("Content-Type")?.indexOf(this.contentType[0]) >= 0;
   }
 
   async optimize(url, response) {

packages/cli/src/plugins/resource/plugin-node-modules.js

@@ -41,14 +41,19 @@ class NodeModulesResource {
   }
 
   async shouldServe(url) {
-    const { href, protocol } = url;
+    const { href, protocol, pathname } = url;
 
-    return protocol === "file:" && (await checkResourceExists(new URL(href)));
+    return (
+      protocol === "file:" &&
+      pathname.indexOf("/node_modules/") >= 0 &&
+      (await checkResourceExists(new URL(href)))
+    );
   }
 
   async serve(url) {
     const body = await fs.readFile(url, "utf-8");
 
+    // most likely a JavaScript file, but perhaps we should further refine based on extension?
     return new Response(body, {
       headers: new Headers({
         "Content-Type": this.contentType,

packages/cli/src/plugins/resource/plugin-standard-html.js

@@ -15,7 +15,7 @@ import { parse } from "node-html-parser";
 class StandardHtmlResource {
   constructor(compilation) {
     this.compilation = compilation;
-    this.extensions = [".html"];
+    this.extensions = ["html"];
     this.contentType = "text/html";
   }