bug(cli): #1323 refine serving logic for node modules plugin#1577
Draft
thescientist13 wants to merge 2 commits into
Draft
bug(cli): #1323 refine serving logic for node modules plugin#1577thescientist13 wants to merge 2 commits into
thescientist13 wants to merge 2 commits into
Conversation
thescientist13
moved this from 👀 In review
to 🏗 In progress
in [Greenwood] Phase 10 - Ecosystem Compat
This was referenced Sep 27, 2025
thescientist13
force-pushed
the
bug/refine-node-modules-plugin-serving
branch
from
9766d81 to
b474f5d
Compare
thescientist13
force-pushed
the
bug/refine-node-modules-plugin-serving
branch
from
b474f5d to
2e883a2
Compare
6 tasks
thescientist13
commented
Jun 27, 2026
| const { activeContent } = this.compilation.config; | ||
|
|
||
| return response.headers.get("Content-Type").indexOf(this.contentType[0]) >= 0 && activeContent; | ||
| return response.headers.get("Content-Type")?.indexOf(this.contentType[0]) >= 0 && activeContent; |
Member
Author
There was a problem hiding this comment.
maybe this order should be reversed, so that we bail right away on the activeContent check, rather that doing the relatively larger check down through the headers.
thescientist13
force-pushed
the
bug/refine-node-modules-plugin-serving
branch
from
2e883a2 to
cc5a4d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#1323
Documentation
N / A
Summary of Changes
Content-Typeheader first in Active Content resource pluginTODO