fix(MMU): use SPVP mode for HLV, HLVX, and HSV PMP checks#6164
Open
fuhuakai wants to merge 1 commit into
Open
Conversation
HLV, HLVX, and HSV instructions may execute from M-mode, but their memory access privilege should be selected by hstatus.SPVP. But the MemBlock PMP checker still used tlbcsr.priv.dmode for all DTLB requests. Fix this by passing the TLB-computed request mode to MemBlock and using it as the PMP check mode for HLV, HLVX, and HSV requests. Normal DTLB requests still use the current privilege mode, and prefetch requests keep the existing prefetch mode.
fuhuakai
requested review from
cebarobot,
good-circle and
linjuanZ
as code owners
github-actions
Bot
added
module: memory
5 tasks
Emu - Performance SummaryMetadata
IPC Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HLV, HLVX, and HSV instructions may execute from M-mode, but their memory access privilege should be selected by hstatus.SPVP. But the MemBlock PMP checker still used tlbcsr.priv.dmode for all DTLB requests.
Fix this by passing the TLB-computed request mode to MemBlock and using it as the PMP check mode for HLV, HLVX, and HSV requests. Normal DTLB requests still use the current privilege mode, and prefetch requests keep the existing prefetch mode.