Skip to content

fix(vstopi): fix the mapping of vsei index#6131

Open
sinceforYy wants to merge 1 commit into
kunminghu-v2from
fix-vstopi-vsei-index
Open

fix(vstopi): fix the mapping of vsei index#6131
sinceforYy wants to merge 1 commit into
kunminghu-v2from
fix-vstopi-vsei-index

Conversation

@sinceforYy

@sinceforYy sinceforYy commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added module: backend Decode, Rename, Issue, Dispatch, Rob, Alu, Csr, fudian, yunsuan topic: functionality To introduce new function, e.g. new isa extensions, new components, bug fixes... labels Jun 24, 2026
@sinceforYy sinceforYy marked this pull request as ready for review June 25, 2026 01:29
@sinceforYy sinceforYy requested a review from Copilot June 25, 2026 01:29
Copilot AI reviewed Jun 25, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts VS-level interrupt priority/index comparisons in InterruptFilter to use the SEI index when handling logic related to VS external interrupts (VSEI being encoded/mapped as SEI in this path).

Changes:

  • Update the VS-level “VSEI priority index” lookup to use SEI’s priority position.
  • Update C4HighVSEI’s comparison threshold from VSEI to SEI in the vstopi candidate selection logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main/scala/xiangshan/backend/fu/NewCSR/InterruptFilter.scala
Comment thread src/main/scala/xiangshan/backend/fu/NewCSR/InterruptFilter.scala Outdated
@XiangShanRobot

XiangShanRobot commented Jun 25, 2026

Copy link
Copy Markdown

[Generated by IPC robot]
commit: a20fcbf

commit astar copy_and_run coremark gcc gromacs hmmer-Vector lbm linux mcf microbench milc namd povray wrf xalancbmk
a20fcbf 1.802 0.440 2.638 1.234 2.149 1.808 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314

kunminghu-v2 branch:

commit astar copy_and_run coremark gcc gromacs hmmer-Vector lbm linux mcf microbench milc namd povray wrf xalancbmk
2acbf32 1.802 0.440 2.638 1.234 2.149 1.808 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314
098fa58 1.802 0.440 2.638 1.234 2.149 1.808 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314
5b82411 1.802 0.440 2.638 1.234 2.149 1.810 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314
38aedc2 1.802 0.440 2.638 1.234 2.149 1.810 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314
7ce99d4 1.802 0.440 2.638 1.234 2.149 1.810 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314
9f988c0 1.802 0.440 2.638 1.234 2.149 1.808 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314
a178aa5 1.802 0.440 2.638 1.234 2.149 1.808 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314

@sinceforYy sinceforYy force-pushed the fix-vstopi-vsei-index branch from a20fcbf to c74baec Compare June 25, 2026 06:23
@sinceforYy sinceforYy requested a review from Copilot June 25, 2026 06:24
Copilot AI reviewed Jun 25, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread src/main/scala/xiangshan/backend/fu/NewCSR/InterruptFilter.scala
private val meiPrioIdx = InterruptNO.getPrioIdxInGroup(_.interruptDefaultPrio)(_.MEI).U
private val seiPrioIdx = InterruptNO.getPrioIdxInGroup(_.interruptDefaultPrio)(_.SEI).U
private val vseiPrioIdx = InterruptNO.getPrioIdxInGroup(_.interruptDefaultPrio)(_.VSEI).U
private val vseiPrioIdx = InterruptNO.getPrioIdxInGroup(_.interruptDefaultPrio)(_.SEI).U
Comment thread src/main/scala/xiangshan/backend/fu/NewCSR/InterruptFilter.scala
val C4HighVSEI = iidC4Idx < findIndex(InterruptNO.VSEI.U)
val SEIHighC4 = findIndex(InterruptNO.SEI.U) < iidC4Idx
val SEIIdx = findIndex(InterruptNO.SEI.U)
val C4HighVSEI = iidC4Idx < SEIIdx
@XiangShanRobot

XiangShanRobot commented Jun 25, 2026

Copy link
Copy Markdown

[Generated by IPC robot]
commit: c74baec

commit astar copy_and_run coremark gcc gromacs hmmer-Vector lbm linux mcf microbench milc namd povray wrf xalancbmk
c74baec 1.802 0.440 2.638 1.234 2.149 1.808 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314

kunminghu-v2 branch:

commit astar copy_and_run coremark gcc gromacs hmmer-Vector lbm linux mcf microbench milc namd povray wrf xalancbmk
2acbf32 1.802 0.440 2.638 1.234 2.149 1.808 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314
098fa58 1.802 0.440 2.638 1.234 2.149 1.808 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314
5b82411 1.802 0.440 2.638 1.234 2.149 1.810 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314
38aedc2 1.802 0.440 2.638 1.234 2.149 1.810 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314
7ce99d4 1.802 0.440 2.638 1.234 2.149 1.810 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314
9f988c0 1.802 0.440 2.638 1.234 2.149 1.808 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314
a178aa5 1.802 0.440 2.638 1.234 2.149 1.808 2.151 2.359 0.932 1.408 1.514 3.103 2.544 2.270 3.314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

module: backend Decode, Rename, Issue, Dispatch, Rob, Alu, Csr, fudian, yunsuan topic: functionality To introduce new function, e.g. new isa extensions, new components, bug fixes...

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sinceforYy @XiangShanRobot