fix(stopi): fix siprios should be masked by sie or hie#6128
Open
sinceforYy wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the masking logic for S-level AIA interrupt priority registers (siprio*) so that their effective outputs are masked by either sie or hie (consistent with HS-level interrupt enable behavior), and wires hie through the existing HasIeBundle plumbing.
Changes:
- Update
siprio0/siprio2/sipriosmask generation to usesie | hieinstead of onlysie. - Extend
HasIeBundleto includehieand connect it fromNewCSRto alliregipriosmodules.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/main/scala/xiangshan/backend/fu/NewCSR/NewCSR.scala |
Connects hie.regOut into all CSR modules that mix in HasIeBundle, ensuring the new input is driven. |
src/main/scala/xiangshan/backend/fu/NewCSR/CSRAIA.scala |
Masks siprio* outputs by sie OR hie, and adds hie to HasIeBundle so the mask can be computed correctly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
[Generated by IPC robot]
kunminghu-v2 branch:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.