Skip to content

misc: Extend manual perf timeout#932

Merged
jensen-yan merged 1 commit into
xs-devfrom
codex/manual-perf-12h-timeout
Jun 30, 2026
Merged

misc: Extend manual perf timeout#932
jensen-yan merged 1 commit into
xs-devfrom
codex/manual-perf-12h-timeout

Conversation

@jensen-yan

@jensen-yan jensen-yan commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Manual performance runs can cover SMT or other long-running benchmark sets. The reusable perf workflow already supports a configurable timeout, but manual-perf did not pass an override.

Approach

Pass timeout_minutes: 720 from manual-perf.yml to the reusable perf template, raising manual performance runs to a 12 hour limit while leaving the template default unchanged.

Validation

  • git diff --check -- .github/workflows/manual-perf.yml .github/workflows/gem5-perf-template.yml
  • Ruby YAML parse for .github/workflows/manual-perf.yml and .github/workflows/gem5-perf-template.yml

Note: actionlint is not installed in this environment.

Summary by CodeRabbit

  • Chores
    • Extended the maximum runtime for the manual performance test workflow, allowing longer performance runs to complete without timing out.

Change-Id: Ie4e618f564560b92dba89bd6ac5727032444a114
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fbdae031-ae62-4f0b-8f7c-e8d5f9a4ca42

📥 Commits

Reviewing files that changed from the base of the PR and between d483117 and fa6ca23.

📒 Files selected for processing (1)
  • .github/workflows/manual-perf.yml

📝 Walkthrough

Walkthrough

Adds timeout_minutes: 720 to the perf_test job in .github/workflows/manual-perf.yml when invoking the reusable gem5-perf-template.yml workflow, setting an explicit 12-hour maximum runtime.

Changes

Manual Perf Workflow Timeout

Layer / File(s) Summary
Add timeout to perf_test job
.github/workflows/manual-perf.yml
Passes timeout_minutes: 720 to the reusable gem5-perf-template.yml workflow for the perf_test job.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • OpenXiangShan/GEM5#923: Also adds timeout_minutes: 720 to a caller of gem5-perf-template.yml, applying the same extended timeout pattern to a different workflow.

Poem

🐇 Tick-tock, the clock runs long,
Twelve hours to prove the benchmark strong.
A single line, a timeout set,
No perf test gone too soon, I bet!
Hippity-hop, the workflow's right. ✅

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/manual-perf-12h-timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jensen-yan jensen-yan marked this pull request as ready for review June 30, 2026 03:50
Copilot AI review requested due to automatic review settings June 30, 2026 03:50
@jensen-yan jensen-yan merged commit c339907 into xs-dev Jun 30, 2026
2 of 3 checks passed
@jensen-yan jensen-yan deleted the codex/manual-perf-12h-timeout branch June 30, 2026 03:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the maximum runtime for manually triggered performance runs by passing a higher timeout_minutes value into the existing reusable performance workflow template, without changing the template’s default behavior for other callers.

Changes:

  • Pass timeout_minutes: 720 from manual-perf.yml into the reusable gem5-perf-template.yml workflow call.
  • Increase manual perf job timeout to 12 hours while keeping the template default at 360 minutes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

🚀 Coremark Smoke Test Results

Branch IPC Change
Base (xs-dev) 2.3162 -
This PR 2.3162 ➡️ 0.0000 (0.00%)

✅ Difftest smoke test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants