misc: Extend manual perf timeout#932
Conversation
Change-Id: Ie4e618f564560b92dba89bd6ac5727032444a114
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds ChangesManual Perf Workflow Timeout
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR extends the maximum runtime for manually triggered performance runs by passing a higher timeout_minutes value into the existing reusable performance workflow template, without changing the template’s default behavior for other callers.
Changes:
- Pass
timeout_minutes: 720frommanual-perf.ymlinto the reusablegem5-perf-template.ymlworkflow call. - Increase manual perf job timeout to 12 hours while keeping the template default at 360 minutes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🚀 Coremark Smoke Test Results
✅ Difftest smoke test passed! |
Motivation
Manual performance runs can cover SMT or other long-running benchmark sets. The reusable perf workflow already supports a configurable timeout, but manual-perf did not pass an override.
Approach
Pass
timeout_minutes: 720frommanual-perf.ymlto the reusable perf template, raising manual performance runs to a 12 hour limit while leaving the template default unchanged.Validation
git diff --check -- .github/workflows/manual-perf.yml .github/workflows/gem5-perf-template.yml.github/workflows/manual-perf.ymland.github/workflows/gem5-perf-template.ymlNote:
actionlintis not installed in this environment.Summary by CodeRabbit