Skip to content

Add extra args2#927

Merged
jensen-yan merged 2 commits into
xs-devfrom
add-extra-args2
Jun 29, 2026
Merged

Add extra args2#927
jensen-yan merged 2 commits into
xs-devfrom
add-extra-args2

Conversation

@jensen-yan

@jensen-yan jensen-yan commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features
    • Added an optional extra_args input to the manual performance workflow, letting you pass additional gem5 arguments when running .py configs.
    • The new input is now included in the performance test workflow call alongside existing benchmark, vector, and memory configuration options.

Copilot AI review requested due to automatic review settings June 29, 2026 07:25
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jensen-yan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6b362bb0-88c5-4848-9d03-3deae7577dad

📥 Commits

Reviewing files that changed from the base of the PR and between 2cec07f and 2ba6199.

📒 Files selected for processing (2)
  • .github/workflows/gem5-perf-template.yml
  • .github/workflows/manual-perf.yml
📝 Walkthrough

Walkthrough

A new extra_args string input (default '') is added to the workflow_dispatch trigger in the manual performance workflow. This input is forwarded into the perf_test reusable workflow call via with.extra_args.

Manual Perf Workflow

Layer / File(s) Summary
extra_args input and forwarding
.github/workflows/manual-perf.yml
Declares extra_args as a workflow_dispatch input and passes it to the perf_test reusable workflow call alongside existing parameters.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • OpenXiangShan/GEM5#925: Modifies the same manual-perf.yml workflow around extra_args and reusable workflow parameter passing.

Poem

🐇 A little arg hops into the flow,
Extra params now have a place to go.
With .py configs it works just right,
Dispatched by hand into the night.
The rabbit cheers — the wiring's tight! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the main change because it describes adding extra args support to the workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-extra-args2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the manual performance GitHub Actions workflow to allow passing through an additional extra_args string to the shared gem5-perf-template.yml workflow, enabling ad-hoc gem5 runtime/config arguments for manual perf runs.

Changes:

  • Add a new workflow_dispatch input extra_args for extra gem5 CLI/config arguments.
  • Forward extra_args into the reusable gem5-perf-template.yml workflow call.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/manual-perf.yml Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/manual-perf.yml:
- Around line 60-65: The extra_args input mapping in the workflow defines
description twice, which makes the YAML invalid. Update the manual-perf workflow
input definition so the extra_args entry keeps only one description value in the
inputs block, preserving the intended wording and removing the duplicate key to
satisfy actionlint, yamllint, and GitHub workflow validation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 85c7d126-4381-4e4b-9254-39af9ac93397

📥 Commits

Reviewing files that changed from the base of the PR and between f2db157 and 2cec07f.

📒 Files selected for processing (1)
  • .github/workflows/manual-perf.yml

Comment thread .github/workflows/manual-perf.yml Outdated
@github-actions

Copy link
Copy Markdown

🚀 Coremark Smoke Test Results

Branch IPC Change
Base (xs-dev) 2.3162 -
This PR 2.3162 ➡️ 0.0000 (0.00%)

✅ Difftest smoke test passed!

Change-Id: I7a22979fbbaece48fcb54a5d3c594e74fa250606
Change-Id: I67001278109b03170ce0f7282b4f60c53a3cca51
@jensen-yan jensen-yan merged commit e90997d into xs-dev Jun 29, 2026
2 checks passed
@jensen-yan jensen-yan deleted the add-extra-args2 branch June 29, 2026 08:04
@github-actions

Copy link
Copy Markdown

🚀 Coremark Smoke Test Results

Branch IPC Change
Base (xs-dev) 2.3162 -
This PR 2.3162 ➡️ 0.0000 (0.00%)

✅ Difftest smoke test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants