Add extra args2#927
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughA new Manual Perf Workflow
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the manual performance GitHub Actions workflow to allow passing through an additional extra_args string to the shared gem5-perf-template.yml workflow, enabling ad-hoc gem5 runtime/config arguments for manual perf runs.
Changes:
- Add a new
workflow_dispatchinputextra_argsfor extra gem5 CLI/config arguments. - Forward
extra_argsinto the reusablegem5-perf-template.ymlworkflow call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/manual-perf.yml:
- Around line 60-65: The extra_args input mapping in the workflow defines
description twice, which makes the YAML invalid. Update the manual-perf workflow
input definition so the extra_args entry keeps only one description value in the
inputs block, preserving the intended wording and removing the duplicate key to
satisfy actionlint, yamllint, and GitHub workflow validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 85c7d126-4381-4e4b-9254-39af9ac93397
📒 Files selected for processing (1)
.github/workflows/manual-perf.yml
🚀 Coremark Smoke Test Results
✅ Difftest smoke test passed! |
Change-Id: I7a22979fbbaece48fcb54a5d3c594e74fa250606
Change-Id: I67001278109b03170ce0f7282b4f60c53a3cca51
35d7f72 to
2ba6199
Compare
🚀 Coremark Smoke Test Results
✅ Difftest smoke test passed! |
Summary by CodeRabbit
extra_argsinput to the manual performance workflow, letting you pass additional gem5 arguments when running.pyconfigs.