Skip to content

cpu: refactor ci, use local dramsim3 all - #590

Merged
jensen-yan merged 2 commits into
xs-devfrom
faster-dramsim3
Nov 5, 2025
Merged

cpu: refactor ci, use local dramsim3 all#590
jensen-yan merged 2 commits into
xs-devfrom
faster-dramsim3

Conversation

@jensen-yan

Copy link
Copy Markdown
Collaborator

Change-Id: I3584235bf1dfbffd0844ba351197aab8247b90af

@jensen-yan
jensen-yan requested a review from Copilot November 4, 2025 10:30
Change-Id: I3584235bf1dfbffd0844ba351197aab8247b90af

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors duplicate DRAMSim3 build steps across multiple GitHub Actions workflows into a reusable composite action to improve maintainability and consistency.

  • Extracts repeated DRAMSim3 build logic into a centralized composite action at .github/actions/build-dramsim/action.yml
  • Replaces 9 instances of inline DRAMSim3 build steps across 4 workflow files with calls to the new action
  • Standardizes the build process to use local cache (/nfs/home/share/gem5_ci/DRAMsim3) to avoid network issues

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/actions/build-dramsim/action.yml New composite action that builds DRAMSim3 from local cache
.github/workflows/pr-quick-check.yml Replaced inline DRAMSim build with action reference
.github/workflows/gem5.yml Replaced 6 inline DRAMSim build steps with action reference
.github/workflows/gem5-vector.yml Replaced inline DRAMSim build with action reference
.github/workflows/gem5-perf-template.yml Replaced inline DRAMSim build with action reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/actions/build-dramsim/action.yml
Comment thread .github/actions/build-dramsim/action.yml
@jensen-yan

Copy link
Copy Markdown
Collaborator Author

/run-spec

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

🚀 Coremark Smoke Test Results

Branch IPC Change
Base (xs-dev) 2.1375 -
This PR 2.1375 ➡️ 0.0000 (0.00%)

✅ Difftest smoke test passed!

@jensen-yan
jensen-yan requested a review from Copilot November 5, 2025 06:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/on-demand-spec.yml
Comment thread .github/workflows/on-demand-spec.yml Outdated
@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown

🚀 Coremark Smoke Test Results

Branch IPC Change
Base (xs-dev) 2.1375 -
This PR 2.1375 ➡️ 0.0000 (0.00%)

✅ Difftest smoke test passed!

also add manually trigger CI perf tests

Change-Id: Iccc2ee49ce632ed201be645f982a2f465b550b88
@jensen-yan
jensen-yan requested a review from Copilot November 5, 2025 07:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jensen-yan
jensen-yan merged commit e9d1d1d into xs-dev Nov 5, 2025
7 checks passed
@jensen-yan
jensen-yan deleted the faster-dramsim3 branch November 5, 2025 07:06
@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown

🚀 Coremark Smoke Test Results

Branch IPC Change
Base (xs-dev) 2.1375 -
This PR 2.1375 ➡️ 0.0000 (0.00%)

✅ Difftest smoke test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants