tests,util: Exclude RTL nodes from distributed defaults - #1059
Conversation
Change-Id: I3c8cba390925f9f18fec60c80fef2eef85ba39fd
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe default distributed server list now excludes ChangesDistributed server defaults
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change only updates distributed-workload default node selection and related descriptions while preserving explicit server selections; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates distributed CI defaults to avoid RTL-reserved nodes while preserving explicit server selections.
Changes:
- Excludes reserved nodes from solver and performance default pools.
- Aligns workflow defaults and manual input descriptions.
- Keeps explicitly supplied server lists unchanged.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Summary |
|---|---|
util/solver/executor/distributed.py |
Updates the solver default pool; nit: synchronize the user guide’s documented default. |
.github/workflows/manual-solve.yml |
Updates the solver default description. |
.github/workflows/manual-perf.yml |
Updates the performance default description. |
.github/workflows/manual-h-spec06-perf.yml |
Updates the H-performance default description. |
.github/workflows/gem5-perf-template.yml |
Updates the shared performance default pool. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🚀 Coremark Smoke Test Results
✅ Difftest smoke test passed! |
Motivation
Keep gem5 distributed CI workloads off node030, node031, and node032 so they do not contend with RTL CI. node035 remains excluded as before.
Approach
Scope
Only default server expansion and its user-facing descriptions change. Scheduling, idle probing, and explicit server selection are unchanged.
Validation
Summary by CodeRabbit