Skip to content

tests,util: Exclude RTL nodes from distributed defaults - #1059

Merged
jensen-yan merged 1 commit into
xs-devfrom
codex/skip-rtl-ci-nodes
Aug 21, 2026
Merged

tests,util: Exclude RTL nodes from distributed defaults#1059
jensen-yan merged 1 commit into
xs-devfrom
codex/skip-rtl-ci-nodes

Conversation

@jensen-yan

@jensen-yan jensen-yan commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Keep gem5 distributed CI workloads off node030, node031, and node032 so they do not contend with RTL CI. node035 remains excluded as before.

Approach

  • Change the shared performance workflow default pool to node020-node029,node033-node034,node036-node039.
  • Keep the solver default pool aligned with the performance workflow.
  • Update manual workflow input descriptions to show the effective default.
  • Leave explicitly supplied server lists unchanged.

Scope

Only default server expansion and its user-facing descriptions change. Scheduling, idle probing, and explicit server selection are unchanged.

Validation

  • Parsed the default solver configuration and confirmed node030-node032 and node035 are absent while adjacent nodes remain present.
  • Parsed all four modified workflow YAML files with PyYAML BaseLoader.
  • Ran Python bytecode compilation for the modified solver executor and CLI.
  • Ran git diff --check.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the default distributed server list to include the correct node ranges.
    • Aligned performance and solve workflow descriptions with the revised server defaults.
    • Preserved existing server nodes while adding the previously omitted nodes.

Change-Id: I3c8cba390925f9f18fec60c80fef2eef85ba39fd
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1072f3d9-7a88-4d40-972f-e3adbfd2f631

📥 Commits

Reviewing files that changed from the base of the PR and between 5361c12 and 1253847.

📒 Files selected for processing (5)
  • .github/workflows/gem5-perf-template.yml
  • .github/workflows/manual-h-spec06-perf.yml
  • .github/workflows/manual-perf.yml
  • .github/workflows/manual-solve.yml
  • util/solver/executor/distributed.py

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The default distributed server list now excludes node030-node032. The executor and four GitHub Actions workflow descriptions use the revised node ranges.

Changes

Distributed server defaults

Layer / File(s) Summary
Update distributed server ranges
util/solver/executor/distributed.py, .github/workflows/*perf*.yml, .github/workflows/manual-solve.yml
The executor default and workflow descriptions now use node020-node029,node033-node034,node036-node039.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 12538

This change only updates distributed-workload default node selection and related descriptions while preserving explicit server selections; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: happy-lx, jueshiwenli

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: excluding RTL nodes from distributed server defaults.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (4 skipped: 4 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/skip-rtl-ci-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jensen-yan
jensen-yan marked this pull request as ready for review August 21, 2026 06:52
Copilot AI lite review requested due to automatic review settings August 21, 2026 06:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates distributed CI defaults to avoid RTL-reserved nodes while preserving explicit server selections.

Changes:

  • Excludes reserved nodes from solver and performance default pools.
  • Aligns workflow defaults and manual input descriptions.
  • Keeps explicitly supplied server lists unchanged.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Summary
util/solver/executor/distributed.py Updates the solver default pool; nit: synchronize the user guide’s documented default.
.github/workflows/manual-solve.yml Updates the solver default description.
.github/workflows/manual-perf.yml Updates the performance default description.
.github/workflows/manual-h-spec06-perf.yml Updates the H-performance default description.
.github/workflows/gem5-perf-template.yml Updates the shared performance default pool.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread util/solver/executor/distributed.py
@github-actions

Copy link
Copy Markdown

🚀 Coremark Smoke Test Results

Branch IPC Change
Base (xs-dev) 2.2448 -
This PR 2.2448 ➡️ 0.0000 (0.00%)

✅ Difftest smoke test passed!

@jensen-yan
jensen-yan merged commit 00ba529 into xs-dev Aug 21, 2026
3 checks passed
@jensen-yan
jensen-yan deleted the codex/skip-rtl-ci-nodes branch August 21, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants