401 response includes WWW-Authenticate header#457
Merged
Conversation
Signed-off-by: João Abbott-Gribben <joao.abbott.gribben@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 83.34% 83.30% -0.04%
==========================================
Files 50 50
Lines 7353 7360 +7
==========================================
+ Hits 6128 6131 +3
- Misses 1225 1229 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stefanvi
requested changes
Jun 30, 2026
Signed-off-by: João Abbott-Gribben <joao.abbott.gribben@gmail.com>
stefanvi
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WWW-Authenticate: Bearer realm="VTN"header to all 401 responses fromAppError.ResponseOAuthErrorinauth.rs) already returned this header forInvalidClient, so this PR closes the gap for bearer token auth failures (invalid/expired JWT, unparseable subject).Approach
AppError::into_response()match to return response tuples from every arm, but instead went for inserting header post-match, based on the response status code.Changes