Return WWW-Authenticate header

[pohlm01]

Whenever we return a 401 Unauthorized we should also include a WWW-Authenticate header.

[joaoag]

@stefanvi or @hugovandepol can I check whether anyone else is working on this / if it's still wanted? I'd like to pick the issue up : )

[stefanvi]

Hi @joaoag, of course, any help is much appreciated! On our end no one is working on this at the moment. I see that currently we do return this header in src/api/auth.rs, I'm not sure in what other places it is needed. Let me know if you need any help getting set up!

[joaoag]

Hi @joaoag, of course, any help is much appreciated! On our end no one is working on this at the moment. I see that currently we do return this header in src/api/auth.rs, I'm not sure in what other places it is needed. Let me know if you need any help getting set up!

Ok great stuff, I've just got the repo up and running (great README btw), tests all passing etc., so hopefully I'm all good with setup. Will reach out if I do get stuck though, appreciate the offer of help : )

[stefanvi]

Good to hear! You should be all set then

[joaoag]

Hey @stefanvi , I've got an initial implementation + test for this change in a local feature branch (committed using the -s flag as per the docs) but I'm unable to push to the remote. Before I sink time into this, can I check whether this is something I can sort out at my end, or do I need to be added to some config on your side?
Thanks in advance

[stefanvi]

Hi @Joaag,

This is probably because you don't have write access to this repository. I am assuming you cloned this repository and made your changes on your local version? (correct me if I'm wrong!)

Typically, the process for external contributors is as follows:

1. You create a fork of the repository.
2. After locally making the changes on a new branch, you push you work to your own fork.
3. Then you can create a pull request to the original repository from the Github web interface.

This process is outlined in https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork.

In your case, you already made the changes on our version of the repository. To fix it, you could create a fork of this repository and then change the remote of your local copy to point to your own fork and push your changes to it. Afterwards you can do step 3. This does however require a bit of command line git knowledge. If you haven't made too many changes, another option is to just go through all the steps, copying over the changes you made previously.

[joaoag]

🤦🏻 of course, sorry yes you identified the issue correctly. Happy to fork and make a PR that way 👍🏻

[joaoag]

@stefanvi here we go, thanks again for all your help so far: https://github.com/OpenLEADR/openleadr-rs/pull/457/changes