Skip to content

Amaresh - Team Member Tasks: Fix dark mode dropdown contrast #5379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amaresh2001 wants to merge 1 commit into
base: development
Choose a base branch
from
+28 −8
Open

Amaresh - Team Member Tasks: Fix dark mode dropdown contrast #5379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/components/TeamMemberTasks/ReviewButton.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,9 @@ function ReviewButton({ user, task, updateTask, onTimeOff }) {
<DropdownMenu
container="body"
strategy="fixed"
className={style['review-button-dropdown']}
className={`${style['review-button-dropdown']} ${
darkMode ? style['review-button-dropdown-dark'] : ''
}`}
>
{task.relatedWorkLinks &&
// eslint-disable-next-line no-shadow
Expand All @@ -500,14 +502,14 @@ function ReviewButton({ user, task, updateTask, onTimeOff }) {
key={sanitizeText(link)}
href={handleSafeLink(link)}
target="_blank"
className={`${darkMode ? 'text-light' : ''} ${style['dark-mode-btn']}`}
className={darkMode ? `text-light ${style['dark-mode-btn']}` : ''}
>
<FontAwesomeIcon icon={faExternalLinkAlt} /> View Link
</DropdownItem>
))}
<DropdownItem
onClick={toggleEditLinkModal}
className={`${darkMode ? 'text-light' : ''} ${style['dark-mode-btn']}`}
className={darkMode ? `text-light ${style['dark-mode-btn']}` : ''}
>
<FontAwesomeIcon icon={faPencilAlt} /> Edit Link
</DropdownItem>
Expand All @@ -534,22 +536,24 @@ function ReviewButton({ user, task, updateTask, onTimeOff }) {
<DropdownMenu
container="body"
strategy="fixed"
className={style['review-button-dropdown']}
className={`${style['review-button-dropdown']} ${
darkMode ? style['review-button-dropdown-dark'] : ''
}`}
>
{task.relatedWorkLinks &&
task.relatedWorkLinks.map(dropLink => (
<DropdownItem
key={sanitizeText(dropLink)}
href={handleSafeLink(dropLink)}
target="_blank"
className={`${darkMode ? 'text-light' : ''} ${style['dark-mode-btn']}`}
className={darkMode ? `text-light ${style['dark-mode-btn']}` : ''}
>
<FontAwesomeIcon icon={faExternalLinkAlt} /> View Link
</DropdownItem>
))}
<DropdownItem
onClick={toggleEditLinkModal}
className={`${darkMode ? 'text-light' : ''} ${style['dark-mode-btn']}`}
className={darkMode ? `text-light ${style['dark-mode-btn']}` : ''}
>
<FontAwesomeIcon icon={faPencilAlt} /> Edit Link
</DropdownItem>
Expand All @@ -558,7 +562,7 @@ function ReviewButton({ user, task, updateTask, onTimeOff }) {
setSelectedAction('Complete and Remove');
toggleVerify();
}}
className={`${darkMode ? 'text-light' : ''} ${style['dark-mode-btn']}`}
className={darkMode ? `text-light ${style['dark-mode-btn']}` : ''}
>
<div className={styles['review-dropdown-item']}>
<FontAwesomeIcon className={styles['team-member-tasks-done']} icon={faCheck} />
Expand All @@ -570,7 +574,7 @@ function ReviewButton({ user, task, updateTask, onTimeOff }) {
setSelectedAction('More Work Needed');
toggleVerify();
}}
className={`${darkMode ? 'text-light' : ''} ${style['dark-mode-btn']}`}
className={darkMode ? `text-light ${style['dark-mode-btn']}` : ''}
>
More work needed, reset this button
</DropdownItem>
Expand Down
16 changes: 16 additions & 0 deletions src/components/TeamMemberTasks/reviewButton.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,22 @@
z-index: 9999;
}

.review-button-dropdown-dark {
background-color: #1c2541 !important;
border-color: #3a506b !important;
}

.dark-mode-btn {
background-color: #1c2541 !important;
color: #f1f1f1 !important;
}

.dark-mode-btn:hover,
.dark-mode-btn:focus {
background-color: #3a506b !important;
color: #fff !important;
}

.reviewBtn-dropdown-wrapper {
display: inline-flex;
align-items: center;
Expand Down
Loading