Amaresh - Team Member Tasks: Fix dark mode dropdown contrast#5379
Amaresh - Team Member Tasks: Fix dark mode dropdown contrast#5379amaresh2001 wants to merge 1 commit into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Amaresh,
I tested this PR locally.
After logging in as an Admin user and checking the Team Member Tasks widget, the Ready for Review dropdown is working fine.
All dropdown items are clickable, and the dropdown text is clearly readable in dark mode. I also toggled back to light mode, and it renders normally without any leftover dark styling.
Everything looks good from my side.
shree-vaths
left a comment
There was a problem hiding this comment.
Hello I tested #5379 on my local. The dark mode visual for ready for review looks good.
Passing Test case
-The drop options have adapted to dark mode when user click of ready for review.
But the edit model is still not readable in dark mode. But I believe its out of scope for this ticket as edit function is not mentioned in requirement.
Issue -
The ledderboard values are missing in dark mode. This looks like some regression issue. Please clarify this as other review comments also has missing leaderboard values for each user.







Description
When a team member has scheduled time off, their row in the Team Member Tasks widget (Dashboard) shows a "[Name] Is Not Available this Week" overlay. In dark mode, the "Ready for Review" dropdown menu (View Link / Edit Link / mark complete / more work needed) rendered with near-white text on a near-white background, making it unreadable. This was one of two issues flagged; PR #5317 (sphurthy-timeoff-hotfix) addressed the functional click-through issue but did not fix this contrast bug.
https://www.loom.com/share/86f58e5b27a3496e998d82ed9f2b89e7
Related PRs (if any):
This is a follow-up to #5317, which fixed the dropdown's disabled/click-through behavior but left the dark mode contrast issue unresolved.
Main changes explained:
reviewButton.module.css: added the.dark-mode-btnclass (dark navy background#1c2541, light text, with hover/focus states), which was previously referenced inReviewButton.jsxbut never defined, so it silently did nothing. Also added.review-button-dropdown-darkfor the dropdown menu container's background.ReviewButton.jsx: bothDropdownMenuinstances (own-task view and reviewer view) now conditionally apply the new dark background class whendarkModeis true; all 6DropdownItemelements now conditionally applytext-light+dark-mode-btntogether only in dark mode (previously the CSS-module class was applied unconditionally regardless of mode, which was harmless only because it didn't exist).How to test:
amaresh/timeoff-review-dropdown-dark-modenpm installand run the app locallyreviewStatus: "Submitted"Screenshots or videos of changes:
Note: