Ethercat master abstraction#97
Open
yguel wants to merge 39 commits into
Open
Conversation
Test Results186 tests +59 152 ✔️ +47 0s ⏱️ ±0s Results for commit b8eaa12. ± Comparison against base commit 396cb1a. This pull request removes 10 and adds 69 tests. Note that renamed tests count towards both.This pull request removes 1 skipped test and adds 13 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
ac813f7 to
b8eaa12
Compare
mcbed
approved these changes
Dec 21, 2023
mcbed
left a comment
Member
There was a problem hiding this comment.
Code OK, extensive hardware tests required
Member
|
Will be re-merged in jazzy after refactoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create master abstraction to enable seemless using of different ethercat masters (e.g. etherlab, SOEM).