Skip to content

Fix like icon position(vertical position) on search page #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matsujun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix like icon position(vertical position) on search page #603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/main/res/layout/item_horizontal_session.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
android:id="@+id/speakers"
android:layout_width="0dp"
android:layout_height="wrap_content"
tools:layout_height="70dp"
tools:layout_height="68dp"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@id/favorite"
app:layout_constraintStart_toStartOf="parent"
Expand All @@ -113,12 +113,12 @@

<io.github.droidkaigi.confsched2018.presentation.common.view.FavoriteButton
android:id="@+id/favorite"
android:layout_height="68dp"

@takahirom takahirom Feb 4, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question 🙋
Why is this height needed? 🤔

@matsujun matsujun Feb 4, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I don't set height, it's wrap_content.
In that case, even if we have only one speaker, the height of favorite is lower than speakers .
So if we don't set this height, the vertical position of favorite and name of speakers are not same.

I think it looks not good, the vertical position of most bottom speaker and like button seems better to be same.

@takahirom takahirom Feb 5, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use constraintbottom_bottomOf="speaker" for favorite?

style="@style/FavoriteButton"
android:checked="@{session.isFavorited}"
app:checkedColorTint="@color/accent"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toBottomOf="@id/title"
app:uncheckedColorTint="@color/sub_icon_color"
/>

Expand Down