Fix like icon position(vertical position) on search page#603
Conversation
Changed to align most bottom speaker vertically. Each speaker icon size is 28dp. it has 4dp margins and speakers area has 16dp top/bottom mergines 28 + 4*2 + 16*2 = 68dp
|
|
||
| <io.github.droidkaigi.confsched2018.presentation.common.view.FavoriteButton | ||
| android:id="@+id/favorite" | ||
| android:layout_height="68dp" |
There was a problem hiding this comment.
I have a question 🙋
Why is this height needed? 🤔
There was a problem hiding this comment.
If I don't set height, it's wrap_content.
In that case, even if we have only one speaker, the height of favorite is lower than speakers .
So if we don't set this height, the vertical position of favorite and name of speakers are not same.
I think it looks not good, the vertical position of most bottom speaker and like button seems better to be same.
There was a problem hiding this comment.
Can we use constraintbottom_bottomOf="speaker" for favorite?
|
Ahhhh... This change looks not needed... |
|
If you have time, I think it would be better to fix the session list together 👀 |
3 participants
Overview (Required)
Sorry... my previous PR had one lack of consideration...
If the session has 2 or 3 speakers, like icon moves up.
It's better to place like icon at same place on every session card.
So I changed to align it to most bottom speaker vertically in this PR.
// Each speaker icon size is 28dp.
// it has 4dp margins
// and speakers area has 16dp top/bottom mergines
// 28 + 4 * 2 + 16 * 2 = 68dp
Screenshot