Security fixes#601
Merged
Merged
Conversation
tyranron
reviewed
Feb 2, 2026
| VALIDITY_LENGTH = 128 # days | ||
| TOKEN_LENGTH = 32 # characters | ||
| VERIFICATION_TOKEN_LENGTH = 20 # characters | ||
| VALIDITY_LENGTH = 3 # days |
There was a problem hiding this comment.
@orta given that there is no information about how this could be configured/changed on the client side (no mentions about session expiration), this change nearly killed the CI usage.
Now I need to renew the session token in CI secrets every three days, which is a huge pain.
There was a problem hiding this comment.
I would be nice for the CLI to allow specifying longer sessions.
Member
Author
There was a problem hiding this comment.
Ah, yeah, that is a pain, lets make this longer 👍🏻
4 tasks
tyranron
added a commit
to instrumentisto/libwebrtc-bin
that referenced
this pull request
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback both from Joshua Rogers and splitline from DEVCORE Research Team (separately)