Changes the expiration time for a session back, but only after it has been confirmed#603
Merged
Conversation
|
Hey @orta, thank you for making this PR to update the CocoaPods token validity back to 128 days. I was also experiencing my token in CI constantly getting expired after the 3 day period, like the folks in this thread. Just curious, what are the next steps for this PR? |
|
looking forward to this fix |
1 task
Member
Author
|
This is good to go now, I just like to leave enough space for some of the other maintainers to have had a chance to leave some feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #601 I dropped the validity time for a token - that was to reduce the search scope potential. However, I think that was a bit harsh https://github.com/CocoaPods/trunk.cocoapods.org/pull/601/changes#r2754437751 a it affects CI pretty badly
This makes it so that an unverified token lives for a shorter time (1 day) but a verified token lives for the original longer time (128 days)