Skip to content

Change Crosstrack mission param display to 1=XTrack Tangent,fix error - #3614

Merged
robertlong13 merged 1 commit into
ArduPilot:masterfrom
Hwurzburg:fix_loiter_to_alt
Nov 8, 2025
Merged

Change Crosstrack mission param display to 1=XTrack Tangent,fix error#3614
robertlong13 merged 1 commit into
ArduPilot:masterfrom
Hwurzburg:fix_loiter_to_alt

Conversation

@Hwurzburg

Copy link
Copy Markdown
Contributor

fix in #3477 was incorrect...thanks to @robertlong13 for catching this

@robertlong13 robertlong13 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also opened a PR about the same time: #3613

Mine just reverts the commit and restores the old column name. If we want to change it, I'm open to that, but

  1. The old name indicates what 1 does, and I don't want to lose that. Just "Crosstrack" isn't specific enough. Admittedly, "0=crosstrack from center,1=crosstrack tangent" would be too long and we'd need something in-between those two options.
  2. We'd need to update LOITER_TURNS and LOITER_TIME to match.

@robertlong13

Copy link
Copy Markdown
Collaborator

Maybe something like "Track (0:ctr,1:tangent)"?

It's still long, but there are longer ones in this file.

@Hwurzburg

Hwurzburg commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

how about "Xtrk-tangent" or "Xtrk-exit-tang", and I will update wiki for all the loiters in the wiki commands listing and in this PR?

@robertlong13

robertlong13 commented Nov 4, 2025

Copy link
Copy Markdown
Collaborator

how about "Xtrk-tangent"

I'd go with "xtrack" over "xtrk". The letters-saved-to-clarity-lost ratio is better.

Everywhere else in mavcmd.xml uses 1=[opt] or [desc] (0:[opt1],1:[opt2]) for these kind of things though, and I think we should stay consistent on that.

So, all that said, I think the best option is 1=Crosstrack Tangent. Here's a comparison of how that looks compared to the old label (and to something shorter like 1=XTrack Tangent). At the default column widths, you can't make out the whole word without the tooltip on any of the options, but you can see the start of "crosstrack" and the start of "tangent" thanks to the line break.

image image image

And for completeness, here's what Track (0:center,1:tangent) looks like. Looks better than I thought it would.

image

I'd be happy with any of (in no particular order)

  • 1=Crosstrack Tangent
  • 1=XTrack Tangent
  • Track (0:center,1:tangent)

@Hwurzburg

Copy link
Copy Markdown
Contributor Author

okay will update this week for all Loiters ....also the wiki

@Hwurzburg

Copy link
Copy Markdown
Contributor Author

@robertlong13 fixed...thanks

@Hwurzburg Hwurzburg changed the title Correct mission params for LOITER_TO_ALT Change Crosstrack mission param display to 1=XTrack Tangent,fix error Nov 8, 2025
@robertlong13
robertlong13 merged commit a3f720a into ArduPilot:master Nov 8, 2025
6 checks passed
@Hwurzburg
Hwurzburg deleted the fix_loiter_to_alt branch November 8, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants