Improve argument validation in hist.c#157
Open
hello8693 wants to merge 1 commit into
Open
Conversation
Contributor
|
Do you have an example use case that gives negative arg1 or arg2? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important fix to the argument validation logic in the
getargsfunction inSrc/hist.c. The change ensures that negative word indices are properly rejected, which improves error handling and prevents potential out-of-bounds access.getargsby explicitly checking for negative values ofarg1andarg2, preventing invalid negative indices from being processed.