ci: add api secondary restore test - #1155
Open
huanghaoyuanhhy wants to merge 1 commit into
Open
Conversation
Signed-off-by: huanghaoyuanhhy <haoyuan.huang@zilliz.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huanghaoyuanhhy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (42.50%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
=======================================
Coverage 42.50% 42.50%
=======================================
Files 136 136
Lines 12181 12181
=======================================
Hits 5178 5178
Misses 6624 6624
Partials 379 379 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire the SECONDARY-tagged pytest
test_restore_secondary.pyinto CI so the HTTP-APIsecondary-restore flow is actually exercised. The test had never run: the api-test matrix
only passes
--tags {L0,L1,L2,RELEASE,RBAC}andpytest-tagsdeselects SECONDARY tests.It was also broken in several ways that a real run exposes:
res["code"] == 200raisedKeyErroron success (successcode=0is omitted by omitempty)source_cluster_id/target_cluster_idnever bound tosourceClusterID/targetClusterIDwith_index_extrahad nothing to capture and the loadstate was not replicated downstream
Changes
tests/testcases/test_restore_secondary.py: fix the success assertion and therestore_secondary field names; add
with_index_extra+format: binlogto the createpayload; prepare indexed/loaded data; assert the backup carries the index extra
attributes (
field_id/user_index_params); verify the restored collections and dataon the downstream (19500) in addition to the upstream.
tests/conftest.py: add--backup_uri_secondaryand--secondary_milvus_urioptionsso the test can reach a downstream-pointed backup server and the downstream Milvus.
.github/workflows/main.yaml: newtest-backup-restore-secondary-apijob that deploysthe existing dual-cluster
deployment/secondaryenvironment, runsinittargettoregister the downstream, starts two backup servers (upstream :8081 for create,
downstream :8082 for restore secondary), and runs
pytest --tags SECONDARY./kind improvement