feat: Split oversized VCS comments into multiple chunks#505
Open
vovinacci wants to merge 2 commits into
Open
Conversation
Reports that exceed the VCS comment size limit (GitHub 64 KB, GitLab 1 MB) are now split into multiple comments at app-level boundaries, with byte-level fallback and markdown repair for oversized single sections. Each chunk carries a numbered header with the kubechecks identifier so multi-instance deployments and TidyOutdatedComments correctly manage comment groups. - Add KUBECHECKS_MAX_COMMENTS_PER_CHECK config (default 0/unlimited) - Add MaxCommentLength() to VCS Client interface - Refactor BuildComment to return []string via new SplitIntoChunks - Rewrite UpdateMessage to delete placeholder and post chunks - Add exponential backoff/retry for multi-chunk posting - Replace silent truncation in PostMessage with hard error - Regenerate mocks and docs Signed-off-by: Volodymyr Shcherbinin (vovin) <vovin@lurk.kyiv.ua>
vovinacci
force-pushed
the
feat/comment-splitting
branch
from
5c99ac6 to
6119650
Compare
Contributor
|
already tested, works perfectly! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reports that exceed the VCS comment size limit (GitHub 64 KB, GitLab 1 MB) are now split into multiple comments using a three-tier structural strategy: whole-app, per-check, and per-line splitting. Every chunk is valid, self-contained markdown with balanced HTML tags - no post-hoc tag repair needed. Each chunk carries a numbered header with the kubechecks identifier so multi-instance deployments and TidyOutdatedComments correctly manage comment groups.
Resolves #504