Skip to content

kube-node-ready-controller: Update to version master-68 - #11939

Merged
katyanna merged 1 commit into
devfrom
container-registry.zalando.net/teapot/kube-node-ready-controller
Aug 14, 2026
Merged

kube-node-ready-controller: Update to version master-68#11939
katyanna merged 1 commit into
devfrom
container-registry.zalando.net/teapot/kube-node-ready-controller

Conversation

@k8s-on-aws-manager-app

@k8s-on-aws-manager-app k8s-on-aws-manager-app Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@k8s-on-aws-manager-app k8s-on-aws-manager-app Bot added dependencies minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call. labels Aug 10, 2026
Update container-registry.zalando.net/teapot/kube-node-ready-controller to version master-68
@mikkeloscar
mikkeloscar force-pushed the container-registry.zalando.net/teapot/kube-node-ready-controller branch from a4e5d42 to 5b027f7 Compare August 11, 2026 10:47
@zalando-robot

Copy link
Copy Markdown

🤖 LLM Suggestions

[High] PR description lacks context on what master-68 changes

The PR description only links to an upstream PR (zalando-build/kube-node-ready-controller#84) without summarising what that PR introduces (bug fix, feature, security patch, etc.). Reviewers and on-call engineers cannot assess the risk of this rollout without knowing what changed in the new image. Please add a short summary of the upstream change and its expected production impact to the PR description.

Other non-critical findings

[Low] No explicit readinessProbe on the DaemonSet pod

The manifest does not define a readinessProbe for the controller container. For a DaemonSet that runs on every node and exposes a /metrics endpoint on port 9090, a minimal HTTP readiness probe would ensure traffic (and node-readiness decisions) are only taken after the controller has fully started. Consider adding:

readinessProbe:
  httpGet:
    path: /healthz
    port: 9090
  initialDelaySeconds: 5
  periodSeconds: 10

(Adjust the path to match whatever health endpoint the controller exposes.)

Tokens Used: Input: 3,988 | Output: 376 | Cache Write: 3,986 | Cache Read: 0 | Total cost: $0.0206

@mikkeloscar

Copy link
Copy Markdown
Contributor

👍

1 similar comment
@katyanna

Copy link
Copy Markdown
Contributor

👍

@katyanna
katyanna merged commit 16df69a into dev Aug 14, 2026
16 checks passed
@katyanna
katyanna deleted the container-registry.zalando.net/teapot/kube-node-ready-controller branch August 14, 2026 10:16
This was referenced Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies merged/kube-1.36 minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants