add toggle to drop lightstep envar injection in admission-controller - #11262
Open
demonCoder95 wants to merge 1 commit into
Open
add toggle to drop lightstep envar injection in admission-controller#11262demonCoder95 wants to merge 1 commit into
demonCoder95 wants to merge 1 commit into
Conversation
demonCoder95
added
the
minor
Member
|
👍 |
Contributor
|
@demonCoder95 did you confirm with observability they are not using the same env variables for Dash0? my guess is this env variables are still in-use, otherwise they would need to force everyone to update the otel sdks. |
Signed-off-by: Noor Malik <noor.malik@zalando.de>
demonCoder95
force-pushed
the
drop-lightstep-envvar-injection
branch
from
June 29, 2026 08:45
4a8165f to
6a717a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we are decommissioning lightstep, we need to drop this environment variable injection in the admission-controller.
This PR introduces a toggle with the default behavior of injection allowed. In a follow-up, we can adjust the e2e tests to drop checking for injection of these variables.