Skip to content

fix: fall back to Redfish session token auth in baremetal agent #24995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fall back to Redfish session token auth in baremetal agent #24995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion pkg/util/redfish/redfish.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ package redfish
import (
"context"
"encoding/base64"
stderrors "errors"
"net"
"net/http"
"net/url"
Expand Down Expand Up @@ -173,7 +174,18 @@ func (r *SBaseRedfishClient) ParseRoot(root jsonutils.JSONObject) error {
func (r *SBaseRedfishClient) Probe(ctx context.Context) error {
resp, err := r.Get(ctx, r.IRedfishDriver().BasePath())
if err != nil {
return errors.Wrap(err, "r.get")
origErr := err
if !r.shouldProbeSessionFallback(err) {
return errors.Wrap(err, "r.get")
}
err = r.Login(ctx)
if err != nil {
return errors.Wrap(origErr, "r.get")
}
resp, err = r.Get(ctx, r.IRedfishDriver().BasePath())
if err != nil {
return errors.Wrap(err, "r.get")
}
}
if r.IsDebug {
log.Debugf("%s", resp.PrettyString())
Expand Down Expand Up @@ -208,6 +220,17 @@ func (r *SBaseRedfishClient) Probe(ctx context.Context) error {
return nil
}

func (r *SBaseRedfishClient) shouldProbeSessionFallback(err error) bool {
if len(r.SessionToken) > 0 {
return false
}
var jerr *httputils.JSONClientError
if !stderrors.As(err, &jerr) {
return false
}
return jerr.Code == http.StatusUnauthorized || jerr.Code == http.StatusForbidden
}

func (r *SBaseRedfishClient) Login(ctx context.Context) error {
sessionurl := httputils.JoinPath(r.IRedfishDriver().BasePath(), "Sessions")
params := jsonutils.NewDict()
Expand Down
Loading
Loading