fix(macos): include tray main-thread crash fix#1
Draft
yorha2B0826 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the
third-party/traysubmodule to the merge commit containing LizardByte/tray#157. That fix ensures macOS UI work performed bytray_update()runs on the main thread.On macOS 27, starting a Moonlight stream with Sunshine's system tray enabled crashes Sunshine with
EXC_BREAKPOINT/SIGTRAP. The crash is triggered from the RTSP handler whilesystem_tray::update_tray_playing()calls into AppKit throughtray_update(). Moonlight then reports TCP 48010 and UDP 48000/48010 as unreachable because the host process has exited.This dependency update carries the already-merged tray fix into Sunshine.
Related issues
Validation
system_tray = enabledand connected from Moonlight to theDesktopapplication. Sunshine loggedNew streaming session startedandCLIENT CONNECTED, opened UDP ports 47998, 47999, and 48000, and remained alive after the tray switched to its streaming state.343of347tests passed;1platform test was skipped.3existing macOS mouse-coordinate tests failed under the active Retina/virtual-display layout due to coordinate scaling. These tests are unrelated to the tray submodule update.Type of change
AI usage