Skip to content

fix(macos): include tray main-thread crash fix#1

Draft
yorha2B0826 wants to merge 1 commit into
masterfrom
agent/macos-tray-main-thread-crash
Draft

fix(macos): include tray main-thread crash fix#1
yorha2B0826 wants to merge 1 commit into
masterfrom
agent/macos-tray-main-thread-crash

Conversation

@yorha2B0826

Copy link
Copy Markdown
Owner

Description

Update the third-party/tray submodule to the merge commit containing LizardByte/tray#157. That fix ensures macOS UI work performed by tray_update() runs on the main thread.

On macOS 27, starting a Moonlight stream with Sunshine's system tray enabled crashes Sunshine with EXC_BREAKPOINT / SIGTRAP. The crash is triggered from the RTSP handler while system_tray::update_tray_playing() calls into AppKit through tray_update(). Moonlight then reports TCP 48010 and UDP 48000/48010 as unreachable because the host process has exited.

This dependency update carries the already-merged tray fix into Sunshine.

Related issues

Validation

  • Built Sunshine successfully on Apple Silicon with macOS 27 using CMake and Ninja.
  • Launched the patched app with system_tray = enabled and connected from Moonlight to the Desktop application. Sunshine logged New streaming session started and CLIENT CONNECTED, opened UDP ports 47998, 47999, and 48000, and remained alive after the tray switched to its streaming state.
  • 343 of 347 tests passed; 1 platform test was skipped.
  • 3 existing macOS mouse-coordinate tests failed under the active Retina/virtual-display layout due to coordinate scaling. These tests are unrelated to the tray submodule update.

Type of change

  • fix: Bug fix

AI usage

  • Heavy: AI assisted with diagnosis, dependency tracing, build validation, and PR preparation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant