YAC-Coupling 2: MPI-YAC-Compatibility 3: #283
Draft
yoctoyotta1024 wants to merge 16 commits into
Draft
Conversation
yoctoyotta1024
force-pushed
the
mpi_yac_step3_twoway_step2
branch
from
ec409f6 to
05fb1c2
Compare
yoctoyotta1024
changed the title
yoctoyotta1024
force-pushed
the
mpi_yac_step3_twoway_step2
branch
5 times, most recently
from
6732956 to
71cb4b5
Compare
yoctoyotta1024
force-pushed
the
mpi_yac_step3_twoway_step2
branch
2 times, most recently
from
8a92c36 to
84bca28
Compare
yoctoyotta1024
changed the title
3 tasks
yoctoyotta1024
changed the title
- Addressed the issue of staggered coupling, by issuing less number of puts in CLEO - Added new put function which calls yac_cput - Still requires some polishing of the code
… and ‘long unsigned int’
match ' coupling_timestep[6] = PT30S; ' in yac_cartesian_dynamics.cpp
- Vertex Longitudes are now calculated using cartesian coordinates from gridbox_bounds - domain definition is modified to support two way coupling in the config file - Miscellaneous YAC related changes to make the two-cpld system more flexible
…a coupling flag to switch between oneway and twoway coupling with ICON.
… debugging comments
see commit: 770d369 note: still cropped at circa. 2.8km in z dimension
- comment out unused variables - no const on int return of function - initialise nullptr explicitly
yoctoyotta1024
force-pushed
the
mpi_yac_step3_twoway_step2
branch
from
9c1070b to
6a04419
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on PR 282. This PR finishes what was begun by PR 282, including:
Also:
To-DO:
upper_latitude/longitude