[Feat] 추천 코스 수정, 삭제 API 구현#63
Merged
Merged
Conversation
2 tasks
chans20
reviewed
Jul 17, 2026
chans20
left a comment
chans20
left a comment
Collaborator
There was a problem hiding this comment.
하신것처럼 CourseItem과 CourseHashtag를 개별 수정하기보다 전체 삭제 후 새 목록으로 교체하는 방식이 더 단순하고 명확해서 좋은것같습니다!
| message = "해시태그는 5개 이하로 선택할 수 있습니다." | ||
| ) | ||
| List<@NotNull(message = "유효하지 않은 해시태그입니다.") Long> hashtagIds, | ||
|
|
Collaborator
There was a problem hiding this comment.
등록 요청에서는 해시태그를 최소 1개 이상 선택하도록 검증하고있어서,
수정 dto에도 min = 1 를 적용하는게 좋을것같습니다.
Member
Author
There was a problem hiding this comment.
해시태그를 전달하지 않으면 해시태그는 수정하지 않는 걸로 하였기 때문에 최소 개수를 검증하지 않고 최대 개수만 검증하도록 했습니다. 확인부탁드립니다!
chans20
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 설명
month_start,month_end필드를 추가하고 관련 로직을 반영했습니다.🔗 연관된 이슈
Resolves: #52
📝 리뷰 요구사항
💻 테스트 결과