#853: wrap GitLab VCS failures#866
Open
GHX5T-SOL wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #853.
This PR updates
GitlabRepoto wrap GitLab API failures raised by issue reads, close attempts, and comment creation. It covers the GitLab response errors from the ticket plus common transport failures, and it replaces the typoedcan' commentread-error text with operation-specific wrapper messages.What changed:
issue,close_issue, andadd_commentrescue handling from onlyGitlab::Error::NotFoundto GitLab API errors plus common transport failuresFaraday::Error,Net::OpenTimeout,Net::ReadTimeout,Errno::ECONNREFUSED, andSocketErrorin the shared GitLab issue-operation rescue listValidation:
PICKS=1 bundle exec rake test TEST=test/test_gitlab.rbin Docker Ruby 3.3 withlibmagic-dev, Maven, and default JRE: 5 tests, 15 assertions, 0 failures, 0 errors, 0 skipsPICKS=1 bundle exec ruby -Itest test/test_gitlab.rbin Docker Ruby 3.3: 5 tests, 15 assertions, 0 failures, 0 errors, 0 skipsbundle exec rubocop objects/vcs/gitlab.rb test/test_gitlab.rb: 2 files inspected, no offenses detectedbundle exec rubocop: 89 files inspected, no offenses detectedgit diff --checkgitleaks dir --no-banner --redact --log-level error .No secrets or credentials used.