Fix failed transaction activity#1312
Open
rossgalloway wants to merge 3 commits into
Open
Conversation
Validate transaction receipt outcomes before marking activity complete.\n\n- Treat reverted receipts as transaction errors\n- Revalidate cached local activity against on-chain receipts\n- Label failed local activity and cover regressions with tests
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Failed Transactions were showing up as successful in the activity tab of the portfolio page. Upon deeper review, this was only for failed transactions in the local cache, which were not being tagged as "failed".
FailedbadgeRoot cause
The transaction overlays used the receipt query's
isSuccessstate as the transaction outcome. That state only means the receipt request completed; the receipt can still have arevertedstatus. Those transactions were persisted as successful local notifications, and the portfolio activity page trusted the cached status.Impact
Failed transactions are no longer recorded as completed. Existing cached success entries are checked against their receipts before display, and reverted entries remain available for auditability with a clear failed state. Indexed activity remains unchanged because reverted transactions do not emit the event logs used by the indexer.
Validation
bun run lint:fixbun run tslintbun run build