feat(ci): add reusable Cloudflare deploy workflow#2
Conversation
9900160 to
0764d51
Compare
murderteeth
left a comment
There was a problem hiding this comment.
before we review this and start reviewing cloudflare deploys, lets establish a spec like we did for vercel deploys, https://hackmd.io/@murderteeth/B1aFfRIXMx. then we can use the cloudflare spec while revieing this pr and our various cloudflare deployed projects.
To me personally i see no difference at all, only vendor changing. The behavior, security guards we did to vercel only need to be translated to cloudflare. UNless im not picking up some slight nuance. Please make me aware! Though if we want to use that as a paper checklist like: |
when i review this work i want to use: |
Oh ok valid point. But i also think the "operation guide" is a needed follow up (maybe on internal-docs? maybe in the gha repo? Possibly there) |
for now lets keep it in a public hackmd so it's easy to reference and link to. i think lets start a new one based on https://hackmd.io/@murderteeth/B1aFfRIXMx and go from there. lets figure out a permanent home later |
Named Wrangler environments are unsupported today; document the default-env-only path.
|
@murderteeth I've also added both to here despite, given it's easy to find and rarely goes away. https://hackmd.io/@V3XqVsqGT2Wqs76oR-sw2A/S1XHZtSEMx - is the hackmd link. |
d6a01a5 to
a70d67b
Compare
Remove the unsupported environment input, enforce bun/wrangler prerequisites, and keep README/spec wording in sync.
Summary
CLOUDFLARE_API_TOKENfrom the sharedwebops-prod-shared/CLOUDFLARE1Password itemwrangler secret bulk, then deploy through the project'sbun run deployscriptWhy
Cloudflare Worker projects need the same reusable, caller-scoped 1Password deployment pattern already available for Vercel projects, with the shared Cloudflare token kept in the shared vault.
Validation
git diff --checkgo run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7