This repository was archived by the owner on Jun 10, 2018. It is now read-only.
Use the default_env normally supplied to sshkit#3
Merged
Conversation
I wanted the console to inherit the default environment specified by `set :default_env` This should also use any loaded framework extensions like rbenv/rvm and bundler.
No functional change, just implementing in a more typical style for a capistrano task.
Owner
|
thanks - looks interesting. Give me a few days to check it out in more detail. |
Contributor
Author
|
Thanks! I'll admit I've only tested this with rbenv and bundler - there may be more involved in an rvm configuration. |
Owner
|
As you suspected, with rvm it doesn't work out of the box. Let's see what happens... |
Contributor
Author
|
Fingers crossed... |
Owner
|
The gem will now add rails to rvm_map_bins itself (dbe6b8b). New release in a few minutes... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The driver for this change is that I wanted the console to inherit the default environment specified by
set :default_envThis should also still use any loaded framework extensions like rbenv/rvm and bundler, via the
SSHKit::Commandinterface.@ydkn please could you consider this change for inclusion in your gem?