fix(search): skip full buffer scan when term is incremental extension#5866
Open
Poonam1216 wants to merge 1 commit into
Open
fix(search): skip full buffer scan when term is incremental extension#5866Poonam1216 wants to merge 1 commit into
Poonam1216 wants to merge 1 commit into
Conversation
When a user types incrementally (e.g. 'hel' → 'hell'), filter existing results instead of re-scanning the entire terminal buffer. This avoids redundant work and improves search responsiveness. - Add isIncrementalExtension() to SearchState to detect when new term extends the cached term - In _highlightAllMatches(), filter existing results when incremental extension is detected instead of doing a full search - Skip optimization for regex and wholeWord searches where filtering existing results would be incorrect Fixes xtermjs#5177
Poonam1216
force-pushed
the
fix/incremental-search-highlighting
branch
from
fe1ce47 to
e3c46cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every keystroke during search triggers a full buffer scan from row 0,
even when the user is just adding characters (e.g. "hel" → "hell").
This causes the 2.5s+ input delay shown in issue #5176 profile.
Solution
When the new term is a plain-text extension of the cached term, filter
the existing results array instead of re-scanning the buffer.
isIncrementalExtension()to SearchState_highlightAllMatches(), filter existing results when incrementalextension is detected
Fixes #5177