fix: iOS Chinese IMEs cannot input punctuation (including space)#5836
Open
someonegg wants to merge 2 commits into
Open
fix: iOS Chinese IMEs cannot input punctuation (including space)#5836someonegg wants to merge 2 commits into
someonegg wants to merge 2 commits into
Conversation
someonegg
force-pushed
the
pr/ios-ime-punctuation-input-fix
branch
from
1d43552 to
872ceb2
Compare
Punctuation is input via non-composition characters; it does not occur immediately at keydown and can be observed reliably at keyup. This commit adds a keyup fallback.
someonegg
force-pushed
the
pr/ios-ime-punctuation-input-fix
branch
from
872ceb2 to
d6635c5
Compare
Clarify comment on keyup method regarding IME behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5835.
On iOS with Chinese IMEs, punctuation (including space) may not be sent to the terminal. The event sequence shows these characters are not reliably available at keydown time (
keyCode=229path), but become observable after input updates and at keyup.This patch adds a keyup fallback path for pending keyCode 229 handling so punctuation/space input can be delivered reliably, including the consecutive-space conversion case (delete-then-insert to
。).