Skip to content

some small changes, but I think these are useful#12

Open
dabzse wants to merge 4 commits into
xriley:masterfrom
dabzse:master
Open

some small changes, but I think these are useful#12
dabzse wants to merge 4 commits into
xriley:masterfrom
dabzse:master

Conversation

@dabzse

@dabzse dabzse commented Jun 30, 2023

Copy link
Copy Markdown
  • text-uppercase appeared twice in the name (originally in line 38): so I just removed one of them
  • removed unnecessary spaces after the last char, and some empty lines, including only the trailing spaces
    • possible those coused by the <enter> button
  • converted tabs to spaces: not everywhere were tabs or spaces. I think developers better like spaces
    • tabs may vary, but scapes are always the same
  • line 122: & to &amp;

did not touch:

  • Prefer to use the native element: role="progressbar"
  • Inline style is not allowed: style="width: {{ $skill }}%"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant