chore: remove dead openwhisprCloudModels data from model registry - #15
Merged
Conversation
The `openwhisprCloudModels` key (fast/balanced/quality tiers) in src/models/modelRegistryData.json was a leftover from the OpenWhispr Electron port. No TypeScript or Rust code read it: the three importers of the registry access `transcriptionProviders` statically, and the one dynamic lookup in ProviderModelSelector is typed to the literal union "transcriptionProviders" | "cloudProviders", so the key was unreachable. Verified with `bun run typecheck` (clean) and `cargo test --manifest-path src-tauri/Cargo.toml` (214 passed, 0 failed).
There was a problem hiding this comment.
🟢 Approval recommended
The removed key is confirmed unreferenced in the repo and the change is a low-risk data cleanup with passing tests reported.
Pull request overview
Removes obsolete OpenWhispr-era tier metadata from the frontend model registry JSON to reduce dead configuration surface area, and records the cleanup in the changelog.
Changes:
- Deleted the unused
openwhisprCloudModelsblock fromsrc/models/modelRegistryData.json. - Added an
[Unreleased]changelog entry under### Internaldocumenting the removal.
File summaries
| File | Description |
|---|---|
| src/models/modelRegistryData.json | Removes the unused openwhisprCloudModels key while keeping the remaining root structure valid (transcriptionProviders, cloudProviders). |
| docs/CHANGELOG.md | Documents the internal cleanup in the Unreleased section. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
xarthurx
added a commit
that referenced
this pull request
Aug 25, 2026
Refresh the provider model registry, recover from provider model retirements instead of failing silently, and restore punctuation in Light and custom-prompt enhancement modes. Conflict resolution against #15 (remove dead openwhisprCloudModels): the tier block is deleted, so the branch's update to it is dropped and the changelog line that referenced its "fast" tier is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Deleted the
openwhisprCloudModelskey (58 lines:fast/balanced/qualitytiers) fromsrc/models/modelRegistryData.json, and added a one-line### Internalnote to the[Unreleased]section ofdocs/CHANGELOG.md.Why
It is dead data — a leftover from the OpenWhispr Electron port. Nothing reads it.
How I verified it is unreferenced
A name grep alone would miss a dynamic key lookup, so I checked both:
node_modules,target,.git) foropenwhisprCloudModelshits only the JSON file itself.modelRegistryData.json:src/components/settings/LiveProviderModelSelector.tsx:39— static.transcriptionProviderssrc/hooks/useLiveDictation.ts:455— static.transcriptionProviderssrc/components/settings/ProviderModelSelector.tsx:34— dynamicmodelRegistry[registryKey], butregistryKeyis typed as the literal union"transcriptionProviders" | "cloudProviders", so the deleted key was unreachable here too.Remaining root keys:
transcriptionProviders,cloudProviders. The file still parses.Test results
bun run typecheck— exit 0, no outputcargo test --manifest-path src-tauri/Cargo.toml— 208 passed (lib) + 6 passed (streaming_mock_ws), 0 failedReviewer note
This proves no code reads the tier data today; it does not prove the data was never intended to be wired up. If a cloud-tier picker is on the roadmap, this removes its seed data — recoverable from history at
44cb3f4.