ci(deny): ignore quick-xml RUSTSEC-2026-0194/0195 pending upstream bump#193
Conversation
Both advisories are DoS-via-untrusted-XML in quick-xml < 0.41. The sole consumer is wayland-scanner, a build-time proc-macro parsing vendored Wayland protocol XML; no untrusted XML is parsed at runtime, so neither issue is reachable in the shipped binary. wayland-scanner 0.31.10 (latest) still pins quick-xml ^0.39 — drop these ignores when it moves to 0.41. Closes #192. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesAdvisory suppression update
Estimated code review effort: 1 (Trivial) | ~3 minutes Related issues: Suggested labels: ci, dependencies, security Suggested reviewers: wrzonance Poem 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Review gate: CodeRabbit produced no walkthrough/review on this PR (green check is only the ack), so Codex (GPT-5.5, adversarial) served as the review gate per the review loop's backup path. Codex verdict — no findings. It independently confirmed the exposure assessment: |
Why
Two RustSec advisories published against
quick-xml 0.39.4(RUSTSEC-2026-0194 quadratic attribute check, RUSTSEC-2026-0195 unbounded namespace allocation) broke the Deny CI job on main and every open PR branch. Both are patched only inquick-xml >= 0.41.0, and the sole consumer —wayland-scanner, a build-time proc-macro parsing vendored Wayland protocol XML — has no release requiring 0.41 yet. Neither DoS is reachable at runtime: HonkHonk never parses untrusted XML.What
Adds temporary, documented
deny.tomlignores for both advisories (same pattern as the existing RUSTSEC-2024-0436 / RUSTSEC-2026-0192 entries), with an explicit removal condition: drop them when wayland-scanner moves to quick-xml 0.41. The same commit is cherry-picked onto the five open PR branches so their CI can settle.Testing
cargo deny checkpasses locally (advisories, bans, licenses, sources all ok)🤖 Co-authored by Claude Fable 5. Closes #192.
Summary by CodeRabbit