Skip to content

[codex] fix tile grid row sizing and rotation clearance#178

Merged
thewrz merged 4 commits into
mainfrom
fix/tile-layout-consistency
Jun 25, 2026
Merged

[codex] fix tile grid row sizing and rotation clearance#178
thewrz merged 4 commits into
mainfrom
fix/tile-layout-consistency

Conversation

@thewrz

@thewrz thewrz commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Keep incomplete sound-grid rows sized from the configured density columns by adding inert blank filler slots.
  • Reserve rotation clearance and fit the visible tile so the current idle and hover-animated rotation stay inside each tile slot.
  • Share the idle and animated rotation bounds between tile painting, hover animation, and layout.
  • Add regression coverage for incomplete-row slot math, rotated tile layout bounds, very narrow slots, and rotation-bound coupling.

Root Cause

Rows were built only from real tiles, so Fill tiles stretched when the final row had fewer than the configured column count. The tile canvas also used the visible tile height as its full layout height, which left no vertical clearance for angled and hover-animated tiles.

Review / Conflict Follow-up

  • Merged origin/main and resolved the sound_tile.rs conflict from the hover/playing tile feedback work.
  • Idle rotation remains +/-3 degrees; hover animation reaches +/-8 degrees; tile layout now reserves for the animated bound.
  • Removed the old speculative scale reserve; this branch now covers the real hover rotation animation instead.

Validation

  • cargo fmt --check
  • cargo test
  • cargo clippy --all-targets -- -D warnings

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@thewrz, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 29 minutes and 44 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d043a6f9-e1a0-4826-b532-a77a0d84d619

📥 Commits

Reviewing files that changed from the base of the PR and between b9d3456 and 6396709.

📒 Files selected for processing (5)
  • src/ui/mod.rs
  • src/ui/sound_grid.rs
  • src/ui/sound_tile.rs
  • src/ui/sound_tile/animation.rs
  • src/ui/tile_layout.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tile-layout-consistency

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thewrz thewrz changed the title [codex] fix tile grid row sizing [codex] fix tile grid row sizing and rotation clearance Jun 25, 2026
@thewrz thewrz marked this pull request as ready for review June 25, 2026 05:44
@thewrz thewrz merged commit ff935bc into main Jun 25, 2026
7 checks passed
@thewrz thewrz deleted the fix/tile-layout-consistency branch June 25, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant