Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,6 @@ steps:
# notify:
# - github_commit_status:
# context: "Unit Tests Keystone"
- label: "🔬 WordPressData Unit Tests"
command: .buildkite/commands/run-unit-tests-for-scheme.sh WordPressData
plugins: [$CI_TOOLKIT_PLUGIN]
artifact_paths:
- "build/results/*"
notify:
- github_commit_status:
context: "Unit Tests WordPressData"

#################
# Linters
Expand Down
3 changes: 1 addition & 2 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,8 @@ WordPress-iOS uses a modular architecture with the main app and separate Swift p
- **Localization**: follow best practices from @docs/localization.md

## Xcode Schemes
- `WordPress` builds the WordPress iOS app and runs `WordPressUnitTests.xctestplan` — default for builds and the full unit test suite.
- `WordPress` builds the WordPress iOS app and runs `WordPressUnitTests.xctestplan` — default for builds and the full unit test suite. Use this scheme to run unit tests.
- `Jetpack` builds the Jetpack iOS app — switch to it for Jetpack-only work.
- Some test targets (e.g. `WordPressDataTests`) have their own scheme and aren't in `WordPressUnitTests.xctestplan`. If the `WordPress` scheme fails to build because of an unrelated target, fall back to the target's dedicated scheme.

## Simulator Sign-In

Expand Down
10 changes: 9 additions & 1 deletion Modules/Sources/WordPressData/Swift/Bundle+WordPressData.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@ import Foundation

extension Bundle {
@objc public class var wordPressData: Bundle {
.module
#if DEBUG
// Workaround for https://forums.swift.org/t/swift-5-3-swiftpm-resources-in-tests-uses-wrong-bundle-path/37051
if let testBundlePath = ProcessInfo.processInfo.environment["XCTestBundlePath"],
let bundle = Bundle(path: "\(testBundlePath)/Modules_WordPressData.bundle")
{
return bundle
}
#endif
return .module
}
}
24 changes: 0 additions & 24 deletions Modules/Tests/WordPressDataTests/WordPressData.xctestplan

This file was deleted.

7 changes: 7 additions & 0 deletions Tests/KeystoneTests/WordPressUnitTests.xctestplan
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,13 @@
"name" : "WordPressMediaLibraryTests"
}
},
{
"target" : {
"containerPath" : "container:..\/Modules",
"identifier" : "WordPressDataTests",
"name" : "WordPressDataTests"
}
},
{
"target" : {
"containerPath" : "container:WordPress.xcodeproj",
Expand Down

This file was deleted.