Fix AI undo redo editor test#25630
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the editor Undo/Redo behavior and related UI test documentation to align with Gutenberg’s granular history, while also improving accessibility and preserving history availability when editor modals are shown/hidden.
Changes:
- Switch Undo/Redo disabled handling from
isUserInteractionEnabledtoisEnabledso disabled state is exposed to accessibility (VoiceOver). - In
NewGutenbergViewController, preserve undo/redo availability across modal open/close by tracking history-disabled state separately from general navigation-item enabled state. - Update the AI agent UI test steps to account for granular undo/redo history (multiple taps may be required).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WordPress/Classes/ViewRelated/Post/PostEditorNavigationBarManager.swift | Initializes undo/redo buttons as disabled via isEnabled (accessibility-visible state). |
| WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift | Tracks nav enabled vs history availability separately and updates undo/redo state consistently when modals close. |
| WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift | Uses isEnabled (not isUserInteractionEnabled) when toggling undo/redo availability. |
| Tests/AgentTests/ui-tests/undo-redo-in-editor.md | Updates agent test procedure to match granular undo/redo behavior and button disabled states. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32476 | |
| Version | PR #25630 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 842de46 | |
| Installation URL | 513rl0uv42d30 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32476 | |
| Version | PR #25630 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 842de46 | |
| Installation URL | 001v494cr5vmo |
38b9ba4 to
be08131
Compare
be08131 to
a701044
Compare
crazytonyli
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary