Skip to content

WPB-18192 Allow collaborators to create team conversations - #4677

Merged
akshaymankar merged 16 commits into
developfrom
WPB-18192-team-conversation-creation-permission-for-collaborators
Jul 24, 2025
Merged

WPB-18192 Allow collaborators to create team conversations#4677
akshaymankar merged 16 commits into
developfrom
WPB-18192-team-conversation-creation-permission-for-collaborators

Conversation

@battermann

@battermann battermann commented Jul 22, 2025 •
edited by akshaymankar
Loading

Copy link
Copy Markdown
Contributor

Also in this PR:

  • Team Collaboarator creation event is only fanned out to team admins and owners
  • Introduce TeamSubsystem to avoid using GalleyAPIAccess from galley.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 22, 2025
@akshaymankar
akshaymankar force-pushed the WPB-18192-team-conversation-creation-permission-for-collaborators branch 3 times, most recently from 9eee988 to a2e9ecf Compare July 23, 2025 12:09
@akshaymankar
akshaymankar force-pushed the WPB-18192-team-conversation-creation-permission-for-collaborators branch from a2e9ecf to 2c78d0d Compare July 23, 2025 12:11
@akshaymankar
akshaymankar force-pushed the WPB-18192-team-conversation-creation-permission-for-collaborators branch from 2c78d0d to 2292dee Compare July 23, 2025 12:18
@akshaymankar akshaymankar changed the title WPB-18192 team conversation creation permission for collaborators WPB-18192 Allow collaborators to create team conversations Jul 24, 2025
@akshaymankar
akshaymankar force-pushed the WPB-18192-team-conversation-creation-permission-for-collaborators branch from 07e806c to 540a501 Compare July 24, 2025 11:00
@akshaymankar
akshaymankar marked this pull request as ready for review July 24, 2025 11:00
@akshaymankar
akshaymankar requested review from a team as code owners July 24, 2025 11:00
supersven
supersven reviewed Jul 24, 2025
View reviewed changes
Comment thread changelog.d/2-features/team-collaborators-convs Outdated
supersven
supersven reviewed Jul 24, 2025
View reviewed changes
Comment thread charts/galley/templates/configmap.yaml Outdated
supersven
supersven reviewed Jul 24, 2025
View reviewed changes
Comment thread charts/galley/values.yaml Outdated
supersven
supersven reviewed Jul 24, 2025
View reviewed changes
Comment thread docs/src/developer/reference/config-options.md Outdated
supersven
supersven reviewed Jul 24, 2025
View reviewed changes
Comment thread hack/helm_vars/wire-server/values.yaml.gotmpl Outdated
supersven
supersven reviewed Jul 24, 2025
View reviewed changes
Comment thread hack/helm_vars/wire-server/values.yaml.gotmpl Outdated
supersven
supersven reviewed Jul 24, 2025
View reviewed changes
Comment thread integration/test/Test/TeamCollaborators.hs Outdated
supersven
supersven reviewed Jul 24, 2025
View reviewed changes
Comment thread libs/extended/src/Hasql/Pool/Extended.hs Outdated
@akshaymankar @supersven
Remove extra whitespace, quotes and 'let's
1530c80 
Co-authored-by: Sven Tennie <sven.tennie@wire.com>
supersven
supersven reviewed Jul 24, 2025
View reviewed changes
Comment thread libs/wire-api/src/Wire/API/Team/Member.hs Outdated
supersven
supersven reviewed Jul 24, 2025
View reviewed changes
Comment thread services/galley/src/Galley/Run.hs
supersven
supersven approved these changes Jul 24, 2025
View reviewed changes

@supersven supersven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@akshaymankar
akshaymankar merged commit c8601cb into develop Jul 24, 2025
9 checks passed
@akshaymankar
akshaymankar deleted the WPB-18192-team-conversation-creation-permission-for-collaborators branch July 24, 2025 14:55
@zebot zebot mentioned this pull request Jul 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akshaymankar akshaymankar akshaymankar left review comments
@supersven supersven supersven approved these changes

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@battermann @akshaymankar @supersven @zebot