Allow HTML to integrate with MakeRealm#1608
Open
annevk wants to merge 1 commit into
Open
Conversation
This complements whatwg/html#12580 to make tc39/ecma262#3728 work. In particular when we allocate a global object we cannot simultaneously expect it to be able to tell us about what is exposed on it. That needs to be known ahead of time. (With this refactoring it is stored on the environment settings object instead.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This complements whatwg/html#12580 to make tc39/ecma262#3728 work.
In particular when we allocate a global object we cannot simultaneously expect it to be able to tell us about what is exposed on it. That needs to be known ahead of time. (With this refactoring it is stored on the environment settings object instead.)
This should be editorial.
💥 Error: 422 Unprocessable Entity 💥
PR Preview failed to build. (Last tried on Jun 15, 2026, 6:07 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build bikeshed/ReSpec specs
🔗 Related URL
Error output:
[ { "lineNum": "10057:22", "messageType": "link", "text": "No 'dfn' refs found for 'global names' with for='['environment settings object']'." }, { "lineNum": "10101:1", "messageType": "link", "text": "No 'dfn' refs found for 'global names' with for='['environment settings object']'." }, { "lineNum": null, "messageType": "failure", "text": "Did not generate, due to errors exceeding the allowed error level." } ]This seems to be an issue with the Spec Generator service. PR Preview doesn't manage this service and so has no control over it. If you've identified an issue with it, you can report the issue to the maintainers of Spec Generator directly. Please be courteous. Thank you!
If you don't have enough information above to solve the error by yourself or if the issue doesn't seem related to Spec Generator, you can file an issue with PR Preview.