Skip to content

Navigation API: Move resolving/rejecting ongoing API method tracker to before running script. #12622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jnjaeschke wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Navigation API: Move resolving/rejecting ongoing API method tracker to before running script. #12622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101702,6 +101702,10 @@ const p2 = navigation.navigate(url2).finished;</code></pre>
<li><p>Set <var>navigation</var>'s <span>ongoing <code data-x="event-navigate">navigate</code>
event</span> to null.</p></li>

<li><p>If <var>navigation</var>'s <span>ongoing API method tracker</span> is non-null, then
<span>reject the finished promise</span> for <var>apiMethodTracker</var> with
<var>reason</var>.</p></li>

<li><p><span>Signal abort</span> on <var>event</var>'s <span
data-x="concept-NavigateEvent-abort-controller">abort controller</span> given
<var>reason</var>.</p></li>
Expand All @@ -101718,10 +101722,6 @@ const p2 = navigation.navigate(url2).finished;</code></pre>
0.</p>
</li>

<li><p>If <var>navigation</var>'s <span>ongoing API method tracker</span> is non-null, then
<span>reject the finished promise</span> for <var>apiMethodTracker</var> with
<var>reason</var>.</p></li>

<li><p><span data-x="concept-event-fire">Fire an event</span> named <code
data-x="event-navigateerror">navigateerror</code> at <var>navigation</var> using
<code>ErrorEvent</code>, with additional attributes initialized according to
Expand Down Expand Up @@ -103381,11 +103381,11 @@ interface <dfn interface>NavigationDestination</dfn> {
<li><p>Set <var>navigation</var>'s <span>ongoing <code data-x="event-navigate">navigate</code>
event</span> to null.</p></li>

<li><p><span data-x="NavigateEvent-finish">Finish</span> <var>event</var> given true.</p></li>

<li><p>If <var>apiMethodTracker</var> is non-null, then <span>resolve the finished
promise</span> for <var>apiMethodTracker</var>.</p></li>

<li><p><span data-x="NavigateEvent-finish">Finish</span> <var>event</var> given true.</p></li>

<li><p><span data-x="concept-event-fire">Fire an event</span> named <code
data-x="event-navigatesuccess">navigatesuccess</code> at <var>navigation</var>.</p></li>

Expand Down
Loading