fix: pre-select weight units from user profile preference - #2439
Open
k-charansai wants to merge 1 commit into
Open
fix: pre-select weight units from user profile preference#2439k-charansai wants to merge 1 commit into
k-charansai wants to merge 1 commit into
Conversation
When creating SlotEntry or WorkoutLog via the API without an explicit weight_unit, the default was always hardcoded to KG (id=1). This change reads the user's profile weight_unit preference and uses it as the default, so users who prefer lbs get lbs pre-selected. Fixes wger-project#2205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2205
Summary
When creating
SlotEntryorWorkoutLogvia the API without an explicitweight_unit, the default was always hardcoded to KG. This change reads the user's profileweight_unitpreference ('kg' or 'lb') and uses it as the default.Changes
wger/manager/api/views.py: Addedperform_createtoSlotEntryViewSetand updatedWorkoutLogViewSet.perform_createto defaultweight_unitfrom user profile preference.wger/manager/tests/test_api_weight_unit_default.py: Added unit tests covering KG/LB defaults and explicit unit overrides.Testing
python manage.py test wger.manager.tests.test_api_weight_unit_default