Repoint secp256k1 dependency to 21-DOT-DEV/swift-secp256k1 - #912
Open
13Ophiuchus wants to merge 8 commits into
Open
Repoint secp256k1 dependency to 21-DOT-DEV/swift-secp256k1#91213Ophiuchus wants to merge 8 commits into
13Ophiuchus wants to merge 8 commits into
Conversation
- Package.swift: swap GigaBitcoin/secp256k1.swift for 21-DOT-DEV/swift-secp256k1 across Web3Core and web3swift targets - PlainKeystore.swift, SECP256k1.swift: import P256K + libsecp256k1 instead of bare secp256k1 module - Matches the dependency used by AGWallet/Package.swift and solana-swift-patched, enabling multi-chain builds (Solana + EVM) without conflicting secp256k1 modules
13Ophiuchus
added a commit
to 13Ophiuchus/AetherAG-mono
that referenced
this pull request
Jul 12, 2026
- Add solana-swift-patched submodule pointing at 13Ophiuchus/solana-swift @ fix/secp256k1-21dotdev (6a4b0dd8) — repoints secp256k1 to 21-DOT-DEV/swift-secp256k1; upstream PR p2p-org/solana-swift#114 - Add web3swift-patched submodule pointing at 13Ophiuchus/web3swift @ fix/secp256k1-21dotdev (f5ba580c) — same dependency fix; upstream PR web3swift-team/web3swift#912 - Both forks resolve the secp256k1/P256K module collision that blocked multi-chain (Solana + EVM) builds - Update AGWallet EVMModule.swift and FlowModule.swift for compatibility with the repointed dependency - Bump AetherAG submodule pointer (regenerated Package.resolved, swift-secp256k1 0.23.2 via 21-DOT-DEV) and Xcode workspace to match - Update MILESTONES.md to reflect Bitcoin signing/address derivation completion and dependency resolution status
13Ophiuchus
added a commit
to 13Ophiuchus/AetherAG-mono
that referenced
this pull request
Jul 12, 2026
- Add solana-swift-patched submodule pointing at 13Ophiuchus/solana-swift @ fix/secp256k1-21dotdev (6a4b0dd8) — repoints secp256k1 to 21-DOT-DEV/swift-secp256k1; upstream PR p2p-org/solana-swift#114 - Add web3swift-patched submodule pointing at 13Ophiuchus/web3swift @ fix/secp256k1-21dotdev (f5ba580c) — same dependency fix; upstream PR web3swift-team/web3swift#912 - Both forks resolve the secp256k1/P256K module collision that blocked multi-chain (Solana + EVM) builds - Update AGWallet EVMModule.swift and FlowModule.swift for compatibility with the repointed dependency - Bump AetherAG submodule pointer (regenerated Package.resolved, swift-secp256k1 0.23.2 via 21-DOT-DEV) and Xcode workspace to match - Update MILESTONES.md to reflect Bitcoin signing/address derivation completion and dependency resolution status
…init in EIP681 ENS resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #911 — repoints secp256k1 to 21-DOT-DEV/swift-secp256k1, matching SolanaSwift's fix in p2p-org/solana-swift#112 (PR p2p-org/solana-swift#113), so apps can use both web3swift and SolanaSwift together.
Verified with a full swift build + swift test in a downstream multi-chain wallet package (25/25 tests passing).