Add --no-gitignore Flag#1590
Merged
Merged
Conversation
Contributor
Author
|
Ready for review! |
guybedford
approved these changes
Jun 12, 2026
Contributor
|
Thanks for following up on this, it may be a couple of weeks yet for the next release when this goes out. |
Contributor
Author
|
Of course! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes or supersedes these issues and PRs:
Closes: #728, #909, #984, #999
Supersedes: #985, #1131, #1408
This PR adds a
--no-gitignoreflag (named that rather than--skip-gitignorefor consistency) to help fix the above issues!After some CI failures, 2 changes were made to make them more robust when running:
Made tmp dir unique with PID suffix: Changed from .".{dirname}" to .".{dirname}-pid{PID}"
Added --target-dir: Pass --target-dir tmp/build to cargo install
You have the latest version of
rustfmtinstalledYou ran
cargo fmton the code base before submittingYou reference which issue is being closed in the PR text.