Issuance request forwarding: Documenting the threat - #550
Draft
simoneonofri wants to merge 1 commit into
Draft
Conversation
c2bo
reviewed
Jul 14, 2026
Comment on lines
+1873
to
+1874
| causing issuance to complete with that other credential manager | ||
| rather than with the credential manager selected by the user. |
Contributor
There was a problem hiding this comment.
We should probably add a note that authorization steps in the protocol might mitigate this? So the result doesn't have to be the issuance to complete.
Something like this?
Suggested change
| causing issuance to complete with that other credential manager | |
| rather than with the credential manager selected by the user. | |
| causing issuance to complete with that other credential manager | |
| rather than with the credential manager selected by the user. Note | |
| that the success of such an attack also depends on possible | |
| authorization steps performed by the underlying | |
| [=digital credential/issuance protocols=]. |
Collaborator
There was a problem hiding this comment.
The "the success of such an attack" reads a little weird.
Projecting forward to the actual mitigation text, what mitigations are in place, for instance, in Openid4vci?
With an example of a mitigation, we might be able to reframe the note a bit.
TallTed
reviewed
Jul 16, 2026
| <strong>Issuance Request Forwarding</strong> | ||
| </dt> | ||
| <dd> | ||
| A malicious [=holder's=] [=credential manager=], such as a digital |
Contributor
There was a problem hiding this comment.
Is it the holder that is malicious, or is it the credential manager? A little rephrasing should be done to make this clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the issuance request forwarding threat to the Security Considerations threat model.
The threat captures the case discussed in #382 where a malicious holder's credential manager, such as a digital wallet, is selected by the user during issuance and forwards the issuance request data to another credential manager on an attacker-controlled device.
Addressing this threat remains under discussion in #382.
Related to #382.
Preview | Diff