Update API to return an array of DigitalCredential instances - #531
Open
mohamedamir wants to merge 1 commit into
Open
Update API to return an array of DigitalCredential instances#531mohamedamir wants to merge 1 commit into
mohamedamir wants to merge 1 commit into
Conversation
This resolves issue #222 by changing the 'discover from external source' algorithm and mock mechanism to resolve with a sequence of DigitalCredential instances rather than a single instance.
mohamedamir
added
agenda+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #222
This PR updates the 'discover from external source' algorithm and mock mechanics to expect multiple responses from the credential chooser/platform, and resolves the credential request Promise with a sequence of DigitalCredential instances rather than a single instance.
Depends on: w3c/webappsec-credential-management#301 (Upstream Web IDL changes allowing navigator.credentials.get() to return a sequence of credentials).
The following tasks have been completed:
Implementation commitment:
Documentation and checks
Preview | Diff