Add support for 3.0.x repo - #247
Conversation
|
@Arakmar thanks for the PR! Can you add some tests for it that use the new repo? |
|
@Arakmar ping :) |
1f16aed to
ca3cc73
Compare
During upgrade test, checking the admin socket file presence is not enough. We need to wait it's really ready to accept connections. The exec is splitted between the two cases : - Initial run and no .my.cnf file, we build the full mysql cmd - .my.cnf already exists, we use it
|
I added one acceptance test about the migration to 3.x. Also, there are no 3.x packages for Debian 11 and Redhat 8 in the proxysql repo. |
SC-specific changes: - Use .my.proxysql.cnf instead of .my.cnf to avoid conflicts with MySQL on hosts running both MySQL and ProxySQL - Remove Sensitive[String] password types and .unwrap calls for compatibility with existing Hiera data and Puppet 7 setups Upstream PR voxpupuli#247 (not yet merged): - Add ProxySQL 3.0.x repository support for APT and YUM - Improve admin socket readiness check: use actual mysql SELECT 1 query instead of just testing socket file existence - Handle first-run (no .my.cnf) vs subsequent runs (with .my.cnf) Document all SC customizations in README.
@Arakmar it's from |
|
We're in exactly this situation right now: on Debian 13 (trixie), upstream only publishes ProxySQL 3.0.x packages — proxysql-2.7.x/trixie/ was never built (HTTP 404), while proxysql-3.0.x/trixie/ exists (currently up to 3.0.10; cf. sysown/proxysql#5179, where trixie support was tied to the 3.0 line). So for trixie users this PR is the only way to keep using the module with a managed repo. Since the branch meanwhile conflicts with master (the rubocop autofix from modulesync touched spec/classes/proxysql_spec.rb), we rebased the two commits onto current master — the only conflict was trailing-comma style in that spec file, everything else applied cleanly: https://github.com/vmpr/puppet-proxysql/tree/add-3.0.x-repo-rebased We're deploying this branch to Debian 13 hosts with ProxySQL 3.0.10 in the next days and can report results here if that helps. On the CI-matrix question above: 3.x packages exist upstream for Debian 12/13 and Ubuntu 22.04/24.04, but not for Debian 11 / EL8 — so the 3.0 acceptance test would need to skip those as long as they stay in metadata.json. Is there anything else we can do to help get this over the line? |
|
Test report — this PR rebased onto current master, ProxySQL 3.0.10 on Debian 13 (trixie), OpenVox 8 As promised: we ran this branch end-to-end on a Debian 13 (trixie) node (OpenVox 8 agent + server), module git-pinned to this PR rebased onto current master (vmpr/puppet-proxysql@add-3.0.x-repo-rebased, manifests identical to fb54e79). Hiera config used: Results:
One note worth a README line (or a future fallback bump): the Hope this helps getting the PR over the line — happy to re-test on demand. |
Support for 3.0.x added for apt and yum repo
The default has been kept to 2.7.x for now